Skip to content

By passing the 100 sms per hour per app limit on android#75

Closed
vaneyck wants to merge 13 commits intoushahidi:developfrom
vaneyck:develop
Closed

By passing the 100 sms per hour per app limit on android#75
vaneyck wants to merge 13 commits intoushahidi:developfrom
vaneyck:develop

Conversation

@vaneyck
Copy link
Copy Markdown
Contributor

@vaneyck vaneyck commented Jan 21, 2013

Hi, So to by pass the 100 sms per hour per app limit on android i have developed a "sms-portal". The "sms-portal" is an app that has a service that works as an sms sender. SMSSync round robins between itself and the sms-portal when sending the messages. Ideally we can have as many senders as we can.
Please have a look and let me know.
Thanks

@mandric
Copy link
Copy Markdown
Collaborator

mandric commented Jan 21, 2013

I thought you could bypass the limit by making a tweak to the Android operating system?

@vaneyck
Copy link
Copy Markdown
Contributor Author

vaneyck commented Jan 22, 2013

Yes you could. But not all users are that tech savvy. They may need a simpler alternative.

@mandric
Copy link
Copy Markdown
Collaborator

mandric commented Jan 22, 2013

You should also probably remove those files that are only relevant to your programming environment.

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Jan 23, 2013

This is really great. However, I would appreciate this approach. The sms-portal app should be a separate app that can be installed from the Google play store. Then it can be enabled from SMSSync settings screen. Once sms-portal is enabled, there should be a prompt to install it if it's not installed already on the device. This way, users have the option to enable it when they need it or not. I'm thinking more in terms of maintenance and portability. What do you guys think?

@vaneyck
Copy link
Copy Markdown
Contributor Author

vaneyck commented Jan 23, 2013

Having it enabled in the settings screen sounds awesome and yes it should be a separate app that should be installed via Google play store. I will see what I can do, then i will send another pull request. Thanks

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Jan 23, 2013

@vaneyck better to keep sms-portal as a separate project. Also, are you willing to maintain it?. Please please keep your dev environment from the repo like @mandric pointed out.

@vaneyck
Copy link
Copy Markdown
Contributor Author

vaneyck commented Jan 23, 2013

@eyedol I don't think i understand what you meant by a separate project. I have the sms-portal app as a separate folder in the same repository as the smssync i.e smssync and sms-portal share the same parent folder in the repo directory structure. Or were you thinking in the lines of a separate repository for sms-portal.
I would mind maintaining it.

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Jan 23, 2013

Yeah would be easier to maintain and manage if it's in it own repository. With this, it's easier to keep track of version numbers and all...

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Mar 29, 2013

ping @vaneyck any updates? Anything I can do to help?

@mandric
Copy link
Copy Markdown
Collaborator

mandric commented Mar 30, 2013

@eyedol i have a branch in my repo (hcb-portals) that includes the portals code, works with or without the portals installed and my callback features. It should merge cleanly but it's not totally done yet. Was also thinking to incorporate an advanced area in the settings for these options.

Also have an sms-portals repo with 4 portals in it, which is totally optional. But I think if you wanted them available on the Market you might need to distribute them separately? No clue on how to manage that.

@vaneyck
Copy link
Copy Markdown
Contributor Author

vaneyck commented Apr 2, 2013

@mandric @eyedol i already created an option for enabling and managing the portals on the settings menu. Maybe we can make like mockups of how we would like the ui to look like. I wouldn't mind implementing it. Design isn't my strong point.
@mandric could you send a pull request with the extra portal code? True, we need to host the portals as separate apps in the play store.

@mandric
Copy link
Copy Markdown
Collaborator

mandric commented Apr 2, 2013

@vaneyck the Advanced panel was just a suggestion. Since it doesn't hurt anything if the user tries to use portals but the extra portals are not installed it doesn't really matter... same with the callbacks stuff... those options don't break anything but do require extra work to get them working.

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Apr 3, 2013

@mandric Let do it. We can distribute the apks on via SMSSync's website. Wished we could do this via github.

@mandric screenshots of the UI you have? We can take it up from there.

@alxndrsn
Copy link
Copy Markdown
Contributor

Hey folks, what's the status of this? Is there code I can check out and have a play with?

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Jul 19, 2013

@alxndrsn @vaneyck did some work on his fork. We wanted this feature to be a configurable option so you can enable or disable when needed. Upon enabling the feature, it prompts the user to install sms-portals which enables SMS to be sent more than 100 x

@vaneyck could you coordinate with @alxndrsn ?

Conflicts:
	abslib/bin/classes/com/actionbarsherlock/internal/nineoldandroids/animation/PropertyValuesHolder.class
	abslib/libs/android-support-v4.jar
	smssync/.classpath
	smssync/.gitignore
	smssync/src/main/java/org/addhen/smssync/MainApplication.java
	smssync/src/main/res/values/strings.xml
	smssync/src/org/addhen/smssync/Prefs.java
	smssync/src/org/addhen/smssync/ProcessSms.java
	smssync/src/org/addhen/smssync/Settings.java
@eyedol eyedol closed this Oct 27, 2013
@alxndrsn
Copy link
Copy Markdown
Contributor

Is it implemented?!?!

@eyedol
Copy link
Copy Markdown
Collaborator

eyedol commented Oct 30, 2013

@alxndrsn No. It has staled and broken at the moment. Not sure of the status.

@vaneyck if you get the chance to implement it let me know. Send a new pull request. I'll review and merge if all is good.

@vaneyck
Copy link
Copy Markdown
Contributor Author

vaneyck commented Oct 30, 2013

Hi,
Sorry for the delay. I will have a look over the weekend, and send a pull request to you by end of next week.

@mandric
Copy link
Copy Markdown
Collaborator

mandric commented Dec 25, 2013

Is there a branch somewhere with the sms-portals support/settings (not portals themselves since those are distributed separately) merged with main SMSSync develop branch? If not I will work on porting/merging it from @vaneyck's branch soon.

Can SMSSync ship to market with the portals settings/support even if the portal apps are not available in the market yet? For now we can just publish 20 portals somewhere to install via non-market/direct download?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants