Merged
Conversation
fixed some variable names to be consistent and a few typos updated couple functions to be private for clarity since they are not called outside of the class added some log lines to help debug crashing when syncing large list of pending messages.
When sync service is not running if you sync pending messages it will clear the list even though they did not sync, as if it worked normally. Make default return value false on ProcessSms.routeMessages. Added error message when service is not running.
Collaborator
|
@mandric Great. Please open an issue with steps on how to replicate it. I'll dig it further. Thanks |
Collaborator
|
@mandric Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up a few things and fixed a bug as you can see in the commit message.
Also was trying to debug a crash/unstable activity when syncing a lot of pending messages (> 300) after an import all at once. I should/will open an issue for that soon unless you want to try to replicate that.