Conversation
amyleadem
changed the title
mejiaj
suggested changes
Nov 29, 2023
mejiaj
left a comment
mejiaj
left a comment
There was a problem hiding this comment.
@mahoneycm minor change, otherwise good.
mejiaj
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated banner markup to reflect the latest changes as of
3.6.0Related Issue
Closes #20
Problem statement
The include banner markup fell out of date with USWDS current banner markup. This is evident in some of the classes and component text.
Solution
Replace markup with component example code from our site. I made sure to update file paths to reflect current templating specs.
I've also made a small change to the preview code example to match the closing tags of the banner. Hopefully, this will prevent any confusion.
Testing & review
Part Fivematch actual banner closing tags