SWR キャッシュによる UX の改善となんか挙動に文句言われたので SQL 書き直した #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aster-void
requested review from
GuY8528,
KaichiManabe and
nakaterm
and removed request for
GuY8528,
KaichiManabe and
nakaterm
KaichiManabe
reviewed
Oct 2, 2024
Contributor
KaichiManabe
left a comment
KaichiManabe
left a comment
There was a problem hiding this comment.
なんかいい気がするが、夜中に見てもよく分からん...
aster-void
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRの概要
closes #302
useSWR を Friend ページと Chat ページに適用
具体的な変更内容
Friend + Chat。
Settings の Course は難しくて一旦パス。
Home は SWR と相性が悪い (すると Twitter みたいに出てきた人がすぐ流れるようになる) ので Skeleton UI などにする予定。
あとなんか Home 触ってたら #301 と #296 も直ったので、 close #301 and close #296 。
影響範囲
Home 以外すべてのページとHome。
動作要件
なし。
レビューリクエストを出す前にチェック！