recommender を更新する #575
Merged
recommender を更新する #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakaterm
reviewed
Jan 14, 2025
| test("recommendation engine", async () => { | ||
| const usersFor101 = await recommendedTo(101, 5, 0); | ||
| if (!usersFor101.ok) throw new Error(); | ||
| if (!usersFor101.ok) throw console.error(usersFor101.error); |
Contributor
There was a problem hiding this comment.
これ undefined が throw されません？
Contributor
Author
There was a problem hiding this comment.
テストなので失敗すればなんでもいいかなと思ってこうしました
Contributor
Author
There was a problem hiding this comment.
前のだとエラーの情報が消えるので
nakaterm
approved these changes
Jan 15, 2025
Closed
nakaterm
pushed a commit
that referenced
this pull request
Mar 6, 2025
ルール:
タグと授業のかぶっている数それぞれを合計して、それの降順で並べる。
## 具体的な変更内容
## 影響範囲
## 動作要件
## 補足
## レビューリクエストを出す前にチェック！
- [ ] 改めてセルフレビューしたか
- [ ] 手動での動作検証を行ったか
- [ ] server の機能追加ならば、テストを書いたか
- 理由: 書いた | server の機能追加ではない
- [ ] 間違った使い方が存在するならば、それのドキュメントをコメントで書いたか
- 理由: 書いた | 間違った使い方は存在しない
- [ ] わかりやすいPRになっているか
<!-- レビューリクエスト後は、Slackでもメンションしてお願いすることを推奨します。 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ルール:
タグと授業のかぶっている数それぞれを合計して、それの降順で並べる。
具体的な変更内容
影響範囲
動作要件
補足
レビューリクエストを出す前にチェック！