Skip to content

Conversation

@meltingrabbit
Copy link
Collaborator

概要

Add formatter (black) and linter (flake8)

Issue

詳細

検証結果

c2a coreに対して動かして差分が出なければOK

@meltingrabbit meltingrabbit added enhancement New feature or request priority::medium priority medium tools labels Jan 19, 2022
@meltingrabbit meltingrabbit self-assigned this Jan 19, 2022
@meltingrabbit
Copy link
Collaborator Author

flake8の出力がちょっと判断できないので,明日の定例で少し話してから修正する.

@meltingrabbit meltingrabbit force-pushed the feature/add_black_and_flake8_ci branch from 06c7ac9 to 5e6db15 Compare January 21, 2022 15:49
@meltingrabbit
Copy link
Collaborator Author

@yngyu or @chutaro こちらも全部消えました.レビューお願いします.

@meltingrabbit
Copy link
Collaborator Author

C2A coreのテストを回し直したら落ちたので,expectを少し修正

return _send_cmd_and_confirm(ope, func_send_cmd, cmd_code, cmd_args, tlm_code_hk)
return _send_cmd_and_confirm(
ope,
lambda cmd_code, cmd_args: ope.send_rt_cmd(cmd_code, cmd_args),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[zatsu] これこんな書き方出来るんですね

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんか,これが正しい書き方っぽい?(わからん.こうしないと怒られるんよね.).

@meltingrabbit meltingrabbit merged commit 08035d7 into main Jan 24, 2022
@meltingrabbit meltingrabbit deleted the feature/add_black_and_flake8_ci branch January 24, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority::medium priority medium tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants