-
Notifications
You must be signed in to change notification settings - Fork 11
Feature/add regex test #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add regex test #15
Conversation
* Move test project to a dedicated location * Fix generated coverage, and check file paths for utPLSQL#11 * Checks output file content (duration should be set to 1)
|
hummm, previous version was testing... nothing :) Not sure using the demo project is a good thing in this case. Which solution do you prefer ? |
|
Look at the file: |
|
Looks like merge done by @alberto-hernandez on commit: 08e3122 reverted the changes so develop does no longer contain the updated script - let me fix that |
(cherry picked from commit 8e387cc)
|
@jgebal, I push some changes in order to parametrize the credentials of the connection in order to pass it from Console for travis build. IMHO, the best approach would be creating other maven-project and use the utplsql-maven-plugin as a plugin-dependency. With this approach you isolate the test phase of each components from the integration test phase. |
|
@alberto-hernandez I agree that we're not writing unit tests but integration tests. They should be moved to an "its" directory and probably run during the "integration-test" phase. Unit tests should mock connection object and java-api (test runner), ensures maven plugin is calling java api right way. |
Ignore windows / mac / linux carriage return differences Ignore test duration differences
jgebal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good, nice work!
Adds test for new regex params (#12) and checks generated output for (#10)