Skip to content

feat(design-verification): add scope-critique pass (#238)#243

Merged
uta2000 merged 4 commits intomainfrom
feat/scope-critique-pass
Apr 17, 2026
Merged

feat(design-verification): add scope-critique pass (#238)#243
uta2000 merged 4 commits intomainfrom
feat/scope-critique-pass

Conversation

@uta2000
Copy link
Copy Markdown
Owner

@uta2000 uta2000 commented Apr 17, 2026

Summary

  • Adds ### Step 4.5: Scope critique step to skills/design-verification/SKILL.md with a 5-question strategic-shape pass (scope, dependencies, simpler alternatives, observability, config surface)
  • New skills/design-verification/references/scope-critique.md with expanded prompt text, per-question red-flag lists, and bias-resistance checklist
  • Wires the pass into Step 4 Consolidation via a call-out that explicitly owns BLOCKER-row promotion into the Step 5 ### Blockers list (labelled [Scope critique Q<N>]), and excludes assumptions-only mode
  • Adds scope-independence Note to Verification Depth so the pass is governed alongside Category 25
  • Pure markdown — zero JS, zero config schema changes, zero hook changes

Motivated by #236 post-creation review: 6 strategic issues bypassed existing brainstorming + design-verification + self-review gates. The new pass fills that gap.

Test Plan

  • AC-1 grep -c "^### Step 4.5: Scope critique" skills/design-verification/SKILL.md1
  • AC-2 grep -c "Should this exist\|Could it ship smaller\|simpler version\|Observability\|Config surface" skills/design-verification/SKILL.md5
  • AC-3 skills/design-verification/references/scope-critique.md exists with expanded prompt text
  • AC-4 Existing SKILL.md anchor count unchanged at 11 (no regression in Step 1-7 / Verification Depth / Quality Rules / Additional Resources headings)
  • AC-5 Manual sanity run against advisor: tiered stuck mode + soft checkpoints + settings hint #236 pre-correction design surfaced 6 of 6 strategic issues (≥3 required)

Code Review Summary

Initial review: pr-review-toolkit:code-reviewer → APPROVED, no blocking issues.

Dogfood + senior-developer panel (opus, 3 personas) surfaced 4 findings, all fixed in this PR:

Severity Persona Rule Fix
important Staff Eng leaky-boundary Step 4 call-out now explicitly owns BLOCKER-row promotion into Step 5 ### Blockers (labelled [Scope critique Q<N>])
important Staff Eng wrong-abstraction Section relocated from ## Scope critique (H2 outside Process) to ### Step 4.5: Scope critique (H3 inside Process); scope-independence Note added to Verification Depth
important Product Eng scope-creep assumptions-only mode now explicitly excluded from the Scope critique pass — matches narrow-mode contract
minor Staff Eng missing-seam Q2 now prefers exploration_results.schema/pipeline/ui evidence first; opens referenced files directly only when the dependency domain is not covered

The scope-critique pass was run against its own design (dogfooding) and produced 2 genuine WARNINGs (Q3 — reference file size trade-off; Q4 — AC-5 is LLM-self-assessed, acknowledged trade-off). Both are noted trade-offs rather than blockers. The pass did NOT surface the assumptions-only scope-creep issue — a blind spot caught by the senior panel's Product Engineer lens.

Implementation Context

Design Decisions

  • Fast-track lifecycle — issue design-verification: add scope-critique pass #238 serves as the design; no separate brainstorming or design doc generated
  • Section placed as ### Step 4.5: Scope critique inside ## Process (between Step 4 and Step 5) so Verification Depth governs it alongside every other check
  • Reference file holds the bias-resistance checklist and per-question red flags; keeping them out of SKILL.md prevents bloat
  • BLOCKER promotion into the top-level Blockers list is owned by the Step 4 Consolidation call-out (single authority), not the Step 4.5 description (which only describes the findings-table output)
  • assumptions-only mode skips the pass — assumption verification is a deliberately narrow mode and strategic critique is out of scope for it

Verification Results

No blockers found during codebase exploration. Senior-panel judgment findings from the review process (4 total) all fixed in this revision.

Key Patterns Used

  • H3 ### Step N: numbered steps inside the ## Process H2 (existing pattern; Step 4.5 inserted between 4 and 5)
  • Scope-independent capabilities noted after the Verification Depth table (parallel to Category 25)
  • Reference files live in skills/<skill-name>/references/
  • Output-format fenced block uses prescriptive severity table (PASS / WARNING / BLOCKER)

Closes #238

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
uta2000 and others added 2 commits April 17, 2026 16:18
Adds a ## Scope critique section to skills/design-verification/SKILL.md and a
supporting reference file with five strategic-shape questions (scope,
dependencies, simpler alternatives, observability, config surface) that run
after the existing compatibility check to catch oversized scope, phantom
dependencies, and unobservable capability bets before a design reaches
create-issue.

Motivated by #236 post-creation review: 6 strategic issues bypassed existing
brainstorming, design-verification, and self-review gates. The new pass fills
that gap with a bias-resistance checklist, red-flag lists per question, and a
findings table that promotes BLOCKER rows to the top-level Blockers list.

Closes #238

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@uta2000 uta2000 force-pushed the feat/scope-critique-pass branch from dc46251 to df51ba1 Compare April 17, 2026 20:19
…236 #238 #239

Aligns version fields across .claude-plugin/plugin.json (already at 1.36.0
from #240), .claude-plugin/marketplace.json, and .feature-flow.yml. Cuts the
[1.36.0] - 2026-04-17 release heading in CHANGELOG.md bundling the five
features shipped today:

- #238 Scope-critique pass for design-verification (PR #243, this PR)
- #236 Advisor tool integration (PR #242)
- #239 Senior developer panel, Phase 1c code review (PR #241)
- #235 Codex consultation, Phase 1+2 opt-in (PR #240)
- #234 Quick-path triage with code-aware scope confirmation (PR #237)

Consolidates .changelogs/238.md fragment into CHANGELOG.md (per the Ship
phase convention) and deletes the fragment. Updates README with a
"What's New in 1.36.0" section listing all five PRs, adds a
Codex Consultation subsection under Optional Enhancements, adds a
Quick-path triage subsection, and updates the Skills table to include
consult-codex and the scope-critique pass note for design-verification.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@uta2000 uta2000 merged commit 8526337 into main Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

design-verification: add scope-critique pass

1 participant