Restrict access to view a user's bookmarks#162
Merged
Conversation
Contributor
Author
|
The last commit implements the BookmarkPolicy to restrict access to showBookmarks view to users with roles: |
Contributor
Author
|
The UserBookmark policy was changed to be implemented in the same way as the UserDelegation Policy. Additionally, authorization was added to the create bookmark ability in the |
- lazy eager loading the bookmarks breaks the display change when unbookmarking. So, we should query fresh. - Moves the bookmark finding logic to the User model - Adds a bookmark `ofType` query scope
wunc
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address vulnerability #2645780 – Low – [profiles.utdallas.edu] IDOR via "/users/[UserName]/boomarks" in the HackerOne report.
Allow access to view a user's bookmarks only if: the logged in user is the owners of the bookmarks.