Skip to content

Comments

Profile Types: Unlisted, In Memoriam#189

Merged
wunc merged 8 commits intodevelopfrom
in-memoriam
Apr 18, 2025
Merged

Profile Types: Unlisted, In Memoriam#189
wunc merged 8 commits intodevelopfrom
in-memoriam

Conversation

@wunc
Copy link
Collaborator

@wunc wunc commented Mar 24, 2025

Add Profile types:

  • Default
  • Unlisted (only shows up when searching or via the url)
  • In Memoriam (like unlisted, but add an "In Memory of" prefix to the profile)

wunc added 5 commits March 20, 2025 15:42
Exclude from:

- API queries
- Tag searches
- Homepage featured profiles
- School profile list
- Browse all profiles list (when not searching)

Unlisted profiles can still show up when using the main site search box.
@wunc wunc linked an issue Mar 24, 2025 that may be closed by this pull request
@wunc wunc requested a review from betsyecastro March 24, 2025 22:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified that unlisted profiles records are not included in the 'Browse All' results (empty search parameters), but they can still appear when searching by name.
  • Verified that unlisted profiles records are not included in the search results with a matching tag, but they can appear if they contain a matching keyword.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified that API index endpoint does not included unlisted profiles records.
  • Verified that unlisted profiles records are still accessible individually via API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified that unlisted profiles records are not included in the profiles results filtered by school.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Type filter works as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verified that profiles names of the type 'unlisted' or 'in memoriam' are not included in the profile picker field in the student research app form.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The updateAdvanced method works as expected, allowing only users with the profile editor role from the same school or department to edit the profile type.

@@ -18,24 +18,33 @@
<label for="publicFilter">Public</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Suggestion: For consistency (even though this is a page for admin access only), this label should read 'Visibility' instead of 'Public' as the table header.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an authorized role for this action, the edit view allows editing this setting. After removing the role in another tab and attempting to save the changes in the first tab, it returns a 403 error, preventing the action from completing.

@wunc wunc merged commit 107e9a3 into develop Apr 18, 2025
1 of 2 checks passed
@wunc wunc deleted the in-memoriam branch April 18, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle deceased faculty

2 participants