Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Pull request overview
Restores/modernizes the repository’s GitHub Actions CI workflows across Windows/Linux/macOS (including CUDA and coverage), while updating build/tooling configuration to support newer toolchains.
Changes:
- Refreshed GitHub Actions workflows (OS/compiler/CUDA matrices, Python 3.12, newer marketplace actions) and improved CUDA install logic.
- Updated CMake/tooling config (new CMake minimum, CUDA-related policy/flag adjustments, code coverage target fixes).
- Minor portability/build fixes in core sources (missing standard headers) and one unit test expectation update.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/UnitTests/VolumeParticleEmitter2Tests.cpp | Updates emitter spacing and expected particle counts in a unit test. |
| Sources/Core/Utils/Logging.cpp | Adds missing <chrono> include for time header generation. |
| Includes/Core/Utils/Logging.hpp | Adds missing <cstdint> include for uint8_t log level enum. |
| Sources/Core/Geometry/Surface.cpp | Adds missing <utility> include for move/exchange usage. |
| Sources/Core/Geometry/Sphere.cpp | Adds missing <utility> include for move/exchange usage. |
| Includes/Core/Matrix/MatrixCSR-Impl.hpp | Adds missing <utility> include (portability). |
| CMakeLists.txt | Raises minimum CMake version and adjusts CUDA/VS-related policy/flags/options. |
| Builds/CMake/CodeCoverage.cmake | Fixes custom target command syntax and improves post-build messaging. |
| .github/workflows/windows.yml | Updates Windows CI matrix, actions versions, and Python setup. |
| .github/workflows/windows-cuda.yml | Updates Windows CUDA CI matrix; improves CUDA install/path discovery; runs CUDA tests conditionally. |
| .github/workflows/ubuntu.yml | Updates Ubuntu CI matrix and Python setup; refreshes package install step. |
| .github/workflows/ubuntu-cuda.yml | Updates Ubuntu CUDA CI and aligns USE_CUDA option; runs CUDA tests conditionally. |
| .github/workflows/ubuntu-codecov.yml | Modernizes Codecov upload and lcov collection. |
| .github/workflows/ubuntu-sonarcloud.yml | Fully comments out SonarCloud workflow content (effectively disables it). |
| .github/workflows/macos.yml | Updates macOS CI matrix and Python setup; changes runner/Xcode selections. |
| .github/workflows/scripts/actions/install_cuda_windows.ps1 | Adds CUDA 12/13 URLs, CUDA 13 package requirements, and robust installer exit-code handling. |
| .github/workflows/scripts/actions/install_cuda_ubuntu.sh | Adds CUDA “compiler” package to installed set. |
| .github/workflows/codeql-analysis.yml | Removes CodeQL scanning workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Skip CUDA unit test execution when the runner has no CUDA-capable GPU, while still running tests when GPU is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision includes: