refactor: replace FastNoise implementation with fastnoise-lite#110
refactor: replace FastNoise implementation with fastnoise-lite#110juyonLee00 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📜 Recent review details🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe bracket-noise crate now declares a dependency on fastnoise-lite version 1.1. This single-line manifest change introduces the external noise generation library to replace direct implementation within the crate. ChangesDependency Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
What
Replaces the legacy
FastNoiseimplementation in bracket-noise with a compatibility wrapper backed byfastnoise-lite.Why
The existing
fastnoise.rsfile was maintained directly by implementing custom noise algorithms.This change reduces maintenance costs by delegating consistent noise generation to
fastnoise-lite. Additionally, the existing wrapper API is retained.Some existing variations are mapped to similar variations available in
fastnoise-lite.Simplex/SimplexFractal->OpenSimplex2Cubic/CubicFractal->ValueCubicRigidMulti->RidgedBillow->PingPongNaturalcellular distance ->HybridSome existing settings are retained for API compatibility even if
fastnoise-litedoes not provide a direct equivalent.Interpis stored but not forwarded tofastnoise-lite.fastnoise-lite.u64, whilefastnoise-liteusesi32, so very large seed values may be truncated.WhiteNoise remains implemented locally because fastnoise-lite does not expose a direct WhiteNoise noise type.
The base frequency remains at 0.0 to maintain the previous bracket-noise initialization behavior.
Adds
fastnoise-liteas a new dependency forbracket-noise.closes #22
Checklist
Required
cargo check --allpassescargo fmt --all -- --checkpassescargo clippy --workspace --all-targets -- -D warnings -A clippy::multiple-crate-versionspassescargo test --allpassesFunctional Validation
Configuration & Docs
README.md,ARCHITECTURE.md, or relevant manual pages, if applicable)If Applicable
cargo auditlocally if needed)Summary by CodeRabbit