Fix container not showing on reconnect

[utkarshdalal]

Summary by CodeRabbit

• Bug Fixes

  • Prevents unintended navigation and dialogs after logon when an environment is already active.
  • Reuses an existing display server to avoid unnecessary reinitialization.
  • Resets GPU textures after surface recreation to prevent rendering artifacts or blank visuals.
  • Improves stability when resuming, reducing crashes and flicker.

• Refactor

  • Streamlined initialization flow to prefer existing runtime environments when available, reducing setup overhead and improving responsiveness.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds guards to skip navigation and environment re-init when an existing xEnvironment is present. XServerScreen now reuses an existing XServer and bypasses environment setup if available. Removes prior environment-shifting path. Renderer resets textures on surface creation via new Texture.invalidate and DrawableManager.all, invalidating all drawables before requesting a render.

Changes

Cohort / File(s)	Summary of changes
Auth/navigation guard app/src/main/java/app/gamenative/ui/PluviaMain.kt	Wrapped the logon-success navigation/dialog logic with a check to run only when PluviaApp.xEnvironment == null. Skips navigation and dialogs if environment exists.
XServer reuse and environment gating app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt	Attempts to reuse an existing XServer from PluviaApp.xEnvironment; otherwise constructs a new one. Executes container/environment initialization only when xEnvironment is null. Removes the environment-shifting path. Passes the chosen server into XServerView.
Rendering reset on surface recreation app/src/main/java/com/winlator/renderer/GLRenderer.java, app/src/main/java/com/winlator/renderer/Texture.java, app/src/main/java/com/winlator/xserver/DrawableManager.java	GLRenderer: on surface creation, locks drawable manager, invalidates textures for all drawables and the root cursor, updates scene, and requests render. Texture: adds invalidate() to reset allocation flags. DrawableManager: adds all() accessor exposing internal SparseArray<Drawable>.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant XServerScreen
  participant PluviaApp
  participant XServerComponent
  participant XServerView

  User->>XServerScreen: Open XServer screen
  XServerScreen->>PluviaApp: Check xEnvironment
  alt xEnvironment is null
    XServerScreen->>XServerScreen: Init container/env
    XServerScreen->>XServerScreen: Create new XServer
  else xEnvironment exists
    XServerScreen->>XServerComponent: Get existing XServer
  end
  XServerScreen->>XServerView: Provide xServerToUse

Loading

sequenceDiagram
  participant GLSurface
  participant GLRenderer
  participant XServer
  participant DrawableManager
  participant Drawable
  participant XServerView

  GLSurface->>GLRenderer: onSurfaceCreated()
  GLRenderer->>XServer: get drawableManager
  GLRenderer->>DrawableManager: all()
  loop each drawable
    GLRenderer->>Drawable: getTexture().invalidate()
  end
  GLRenderer->>Drawable: Invalidate root cursor texture
  GLRenderer->>GLRenderer: updateScene()
  GLRenderer->>XServerView: requestRender()

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• Once more attempted vortek with changes to renderercomponent, etc #108 — Also modifies XServerScreen initialization and component setup, overlapping with environment/server reuse logic introduced here.

Poem

In moonlit bits I twitch my ears,
Reusing servers, clearing smears—
Textures reset, a fresh-drawn sky,
No double-boot to hopify.
Guarded paths, I bounce with cheer,
One hare, one render, crisp and clear. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 74b9b3a and 76a7e69.

📒 Files selected for processing (5)

• app/src/main/java/app/gamenative/ui/PluviaMain.kt (1 hunks)
• app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt (2 hunks)
• app/src/main/java/com/winlator/renderer/GLRenderer.java (2 hunks)
• app/src/main/java/com/winlator/renderer/Texture.java (1 hunks)
• app/src/main/java/com/winlator/xserver/DrawableManager.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch close-container-after-minute

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.