Skip to content

fix: add Korean and Romanian to language switcher, sort by ISO code#1349

Merged
utkarshdalal merged 2 commits into
utkarshdalal:masterfrom
linkq:fix/language-switcher
May 12, 2026
Merged

fix: add Korean and Romanian to language switcher, sort by ISO code#1349
utkarshdalal merged 2 commits into
utkarshdalal:masterfrom
linkq:fix/language-switcher

Conversation

@linkq
Copy link
Copy Markdown
Contributor

@linkq linkq commented May 2, 2026

Description

Add Korean and Romanian to the language switcher options in LocaleHelper.SUPPORTED_LANGUAGES. Both locales already had complete string resource files (values-ko/ and values-ro/) and were already listed in build.gradle.kts resourceConfigurations, but were missing from the in-app language selection menu, making them inaccessible.

Also reorder all entries alphabetically by ISO 639-1 language code for consistent display order.

Recording

b9403098cec1d6e4cae4fd679aef3d6f.mp4

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Add Korean (ko) and Romanian (ro) to the in-app language switcher and sort languages by ISO 639-1 code for a consistent order. "System Default" stays pinned at the top.

Written for commit 0d5c999. Summary will update on new commits.

Summary by CodeRabbit

  • New Features
    • Added Korean and Romanian language support, expanding localization options for users.

linkq added 2 commits May 2, 2026 18:37
Reorder entries alphabetically by their language code key to
ensure consistent ordering in the language switcher. System
Default remains pinned at the top.
@linkq linkq requested a review from utkarshdalal as a code owner May 2, 2026 16:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

📝 Walkthrough

Walkthrough

The PR adds Korean (ko) and Romanian (ro) language codes to the SUPPORTED_LANGUAGES map in LocaleHelper.kt and reorders the existing language entries. The property's type signature remains unchanged.

Changes

Locale Configuration Update

Layer / File(s) Summary
Supported Languages Map
app/src/main/java/app/gamenative/utils/LocaleHelper.kt
SUPPORTED_LANGUAGES map is expanded to include ko (한국어) and ro (Română) language codes, with entries reordered while preserving existing languages (en, es, fr, de, it, pt-BR, ru, uk, zh-CN, zh-TW, pl).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #512 — Provides the Korean resource bundle (values-ko/strings.xml) that corresponds to the ko language code being added.
  • PR #422 — Provides Romanian resources and locale configuration for ro, completing Romanian language support alongside this code change.
  • PR #351 — Also modifies the same SUPPORTED_LANGUAGES map, adding French and other language entries.

Suggested reviewers

  • phobos665

Poem

🐰 Hops with delight
Korean whispers, Romanian cheers,
Languages bloom in the GlobalScope,
East meets West in a map so bright,
CodeRabbit hops through locales with hope! 🌍✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding Korean and Romanian languages and sorting by ISO code, which aligns with the actual modifications in SUPPORTED_LANGUAGES.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description is comprehensive and well-structured, covering all key sections including clear rationale, type of change, recording, and complete checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@utkarshdalal utkarshdalal merged commit 878dde4 into utkarshdalal:master May 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants