fix: add Korean and Romanian to language switcher, sort by ISO code#1349
Merged
Conversation
Reorder entries alphabetically by their language code key to ensure consistent ordering in the language switcher. System Default remains pinned at the top.
Contributor
📝 WalkthroughWalkthroughThe PR adds Korean ( ChangesLocale Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
phobos665
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Korean and Romanian to the language switcher options in
LocaleHelper.SUPPORTED_LANGUAGES. Both locales already had complete string resource files (values-ko/andvalues-ro/) and were already listed inbuild.gradle.ktsresourceConfigurations, but were missing from the in-app language selection menu, making them inaccessible.Also reorder all entries alphabetically by ISO 639-1 language code for consistent display order.
Recording
b9403098cec1d6e4cae4fd679aef3d6f.mp4
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Add Korean (
ko) and Romanian (ro) to the in-app language switcher and sort languages by ISO 639-1 code for a consistent order. "System Default" stays pinned at the top.Written for commit 0d5c999. Summary will update on new commits.
Summary by CodeRabbit