Add ALT + ENTER control action#1498
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds support for the ALT+ENTER key binding in the input control system. The Binding enum gains a new ALT_ENTER constant that is formatted as "ALT + ENTER" and classified as an extra binding. The input event handler explicitly implements the key press/release sequence for this binding via xServer. ChangesALT + ENTER Input Binding
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
phobos665
left a comment
There was a problem hiding this comment.
Looks good to me.
Are there any other potential combinations we may want?
Thanks! There aren't any other combinations that I can think of that would be useful here. But we are missing END, INSERT, = and `/~ keys from the action list too. Should I go ahead and add those as well? Tilde is often used as the developer console for valve games. |
Description
This is a requested feature from here: https://discord.com/channels/1378308569287622737/1510095216009543681
Adds a new control action for ALT + ENTER.
Recording
Screen_Recording_20260531_161927_GameNative.mp4
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Adds an ALT_ENTER binding under Extras that presses Left Alt + Enter on down and releases both on up. This enables a single control to trigger Alt+Enter (commonly used for fullscreen) in apps.
Written for commit 1991d01. Summary will update on new commits.
Summary by CodeRabbit