-
-
Notifications
You must be signed in to change notification settings - Fork 88
Allow steam to run with fex by adding override options #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdded per-executable FEX app-config overrides via new FEXCoreManager APIs and invoked them during X environment setup; removed explicit deletion of FEXCore config files from container utilities. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/java/com/winlator/fexcore/FEXCoreManager.java`:
- Around line 50-67: ensureAppConfigOverrides is writing AppConfig into
"/home/xuser/.config/.fex-emu/AppConfig" while deleteConfigFiles targets
"imagefs/home/xuser/.fex-emu/AppConfig", so align the two: update
ensureAppConfigOverrides (and/or deleteConfigFiles) to derive the same baseDir
from ImageFs.find(context).getRootDir() and use a single canonical path for the
FEX config (e.g., include or omit the ".config" segment consistently), or
extract a shared helper that constructs the baseDir used by both
ensureAppConfigOverrides and deleteConfigFiles so
APP_CONFIG_EXE_NAMES/APP_CONFIG_CONTENT files are created and deleted from the
identical directory.
🧹 Nitpick comments (1)
app/src/main/java/com/winlator/fexcore/FEXCoreManager.java (1)
69-78: Remove unused methodfindAppConfigExeName.This method is not called anywhere in the codebase and should be removed to reduce code clutter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
Summary by cubic
Add FEX AppConfig overrides so Steam and its helper processes run correctly under FEX. Overrides are created at startup and applied during X server setup.
Written for commit e37f75d. Summary will update on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.