fix: release pointer capture when container exits#705
fix: release pointer capture when container exits#705utkarshdalal merged 1 commit intoutkarshdalal:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA pointer capture release operation was added to the application exit handler in XServerScreen. The change releases pointer capture on the touchpad view during cleanup when the application terminates. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Why add a release function* in an activity higher up in the hierarchy, when you can add it at the same level where request happens? |
fix mouse being invisible after exiting container
no need to check if a pointer is captured to begin with, calling releasePointerCapture does nothing if that's the case, per documentation (https://developer.android.com/reference/android/view/View#releasePointerCapture())
Summary by cubic
Release pointer capture when the XServer container exits to prevent the mouse cursor from staying invisible after closing the container.
Written for commit fb049ea. Summary will update on new commits.
Summary by CodeRabbit