Skip to content

feat: Add new manifest attribute to ensure app is classified as a game#709

Merged
utkarshdalal merged 1 commit intoutkarshdalal:masterfrom
Unnvaldr:manifest-mark-app-as-game
Mar 4, 2026
Merged

feat: Add new manifest attribute to ensure app is classified as a game#709
utkarshdalal merged 1 commit intoutkarshdalal:masterfrom
Unnvaldr:manifest-mark-app-as-game

Conversation

@Unnvaldr
Copy link
Contributor

@Unnvaldr Unnvaldr commented Mar 3, 2026

Rationale

The app wasn’t marked as a game, which caused recognition issues on newer Android versions. This is particularly important on Samsung devices, where system features like Game Launcher depend on the app category to detect games correctly.

What Changed

Set the app category to game in the Android manifest.

Impact

No change to core functionality. The app is now properly recognized as a game, especially on Samsung devices, enabling game-specific system features and optimizations. Sorting in the dashboard might change, which could potentially confuse the user at first.


Summary by cubic

Mark the app as a game by setting android:appCategory="game" in AndroidManifest.xml. This ensures proper classification on Android (including Samsung Game Launcher) and enables game-specific system features; no functional changes, but the app may appear under Games and sorting may change.

Written for commit b1725e8. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated app metadata to properly categorize the application.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

📝 Walkthrough

Walkthrough

Added an android:appCategory="game" attribute to the application tag in AndroidManifest.xml. This metadata change categorizes the app as a game without modifying any functional code or control flow logic.

Changes

Cohort / File(s) Summary
Android Manifest Configuration
app/src/main/AndroidManifest.xml
Added android:appCategory="game" attribute to the <application> tag for semantic app categorization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

Hop, hop, hop—the manifest's grown wise,
A game tag added under digital skies,
One tiny attribute, so crisp and so clean,
Now Google knows best what this app's meant to mean! 🎮🐰

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the main change: adding an android:appCategory="game" attribute to the manifest to classify the app as a game.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/src/main/AndroidManifest.xml (1)

30-36: Good addition; consider removing the deprecated android:isGame attribute.

The android:appCategory="game" attribute is the correct modern approach (API 26+). However, android:isGame="true" on line 30 is deprecated since API 26 and is now redundant. Consider removing it to avoid maintaining deprecated code.

,

♻️ Suggested cleanup
     android:extractNativeLibs="true"
     android:icon="${icon}"
-    android:isGame="true"
     android:label="@string/app_name"
     android:supportsRtl="true"
     android:largeHeap="true"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/src/main/AndroidManifest.xml` around lines 30 - 36, Remove the deprecated
android:isGame="true" attribute from the AndroidManifest application element;
keep android:appCategory="game" (API 26+) and ensure attributes like
android:label, android:supportsRtl, android:largeHeap, android:theme, and
android:allowAudioPlaybackCapture remain unchanged—update the application
element where android:isGame appears so only android:appCategory="game" is used.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/src/main/AndroidManifest.xml`:
- Around line 30-36: Remove the deprecated android:isGame="true" attribute from
the AndroidManifest application element; keep android:appCategory="game" (API
26+) and ensure attributes like android:label, android:supportsRtl,
android:largeHeap, android:theme, and android:allowAudioPlaybackCapture remain
unchanged—update the application element where android:isGame appears so only
android:appCategory="game" is used.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 08a27a8 and b1725e8.

📒 Files selected for processing (1)
  • app/src/main/AndroidManifest.xml

@utkarshdalal utkarshdalal merged commit 5b85b3c into utkarshdalal:master Mar 4, 2026
2 checks passed
ObfuscatedVoid pushed a commit to ObfuscatedVoid/GameNative that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants