feat: Add new manifest attribute to ensure app is classified as a game#709
Conversation
📝 WalkthroughWalkthroughAdded an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/src/main/AndroidManifest.xml (1)
30-36: Good addition; consider removing the deprecatedandroid:isGameattribute.The
android:appCategory="game"attribute is the correct modern approach (API 26+). However,android:isGame="true"on line 30 is deprecated since API 26 and is now redundant. Consider removing it to avoid maintaining deprecated code.,
♻️ Suggested cleanup
android:extractNativeLibs="true" android:icon="${icon}" - android:isGame="true" android:label="@string/app_name" android:supportsRtl="true" android:largeHeap="true"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/AndroidManifest.xml` around lines 30 - 36, Remove the deprecated android:isGame="true" attribute from the AndroidManifest application element; keep android:appCategory="game" (API 26+) and ensure attributes like android:label, android:supportsRtl, android:largeHeap, android:theme, and android:allowAudioPlaybackCapture remain unchanged—update the application element where android:isGame appears so only android:appCategory="game" is used.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@app/src/main/AndroidManifest.xml`:
- Around line 30-36: Remove the deprecated android:isGame="true" attribute from
the AndroidManifest application element; keep android:appCategory="game" (API
26+) and ensure attributes like android:label, android:supportsRtl,
android:largeHeap, android:theme, and android:allowAudioPlaybackCapture remain
unchanged—update the application element where android:isGame appears so only
android:appCategory="game" is used.
Rationale
The app wasn’t marked as a game, which caused recognition issues on newer Android versions. This is particularly important on Samsung devices, where system features like Game Launcher depend on the app category to detect games correctly.
What Changed
Set the app category to
gamein the Android manifest.Impact
No change to core functionality. The app is now properly recognized as a game, especially on Samsung devices, enabling game-specific system features and optimizations. Sorting in the dashboard might change, which could potentially confuse the user at first.
Summary by cubic
Mark the app as a game by setting android:appCategory="game" in AndroidManifest.xml. This ensures proper classification on Android (including Samsung Game Launcher) and enables game-specific system features; no functional changes, but the app may appear under Games and sorting may change.
Written for commit b1725e8. Summary will update on new commits.
Summary by CodeRabbit