-
Notifications
You must be signed in to change notification settings - Fork 148
[BUG] API request timeout should always clear its timer #465
Copy link
Copy link
Closed
Labels
area:frontendFrontend React/UI workFrontend React/UI workbeginner friendlySmall scoped task suitable for beginner contributorsSmall scoped task suitable for beginner contributorsgood first issueFriendly starter issue for first-time contributorsFriendly starter issue for first-time contributorslevel:beginner20 pts difficulty label for small beginner-friendly PRs20 pts difficulty label for small beginner-friendly PRspriority:lowNice-to-have issue with low urgencyNice-to-have issue with low urgencytype:bugBug fix work category bonus labelBug fix work category bonus labeltype:testingTesting work category bonus labelTesting work category bonus label
Metadata
Metadata
Assignees
Labels
area:frontendFrontend React/UI workFrontend React/UI workbeginner friendlySmall scoped task suitable for beginner contributorsSmall scoped task suitable for beginner contributorsgood first issueFriendly starter issue for first-time contributorsFriendly starter issue for first-time contributorslevel:beginner20 pts difficulty label for small beginner-friendly PRs20 pts difficulty label for small beginner-friendly PRspriority:lowNice-to-have issue with low urgencyNice-to-have issue with low urgencytype:bugBug fix work category bonus labelBug fix work category bonus labeltype:testingTesting work category bonus labelTesting work category bonus label
Problem
frontend/src/api.tsclears the request timeout afterfetch()resolves. Iffetch()rejects or is aborted, the timeout cleanup path is skipped.Expected behavior
The timeout should be cleared in a
finallyblock so every request path cleans up its timer.Acceptance criteria
finally.