ci: add mutation testing for validation and redaction helpers (#244)#344
Open
aaniya22 wants to merge 3 commits into
Open
ci: add mutation testing for validation and redaction helpers (#244)#344aaniya22 wants to merge 3 commits into
aaniya22 wants to merge 3 commits into
Conversation
Fixes utksh1#265 - config.py: removed 'secuscan-dev-key' hardcoded fallback in resolved_vault_key(). Now raises ValueError at startup if SECUSCAN_VAULT_KEY is not explicitly set in environment. - vault.py: replaced broken XOR stream cipher with AES-256-GCM via the cryptography package. XOR with a 32-byte cycling keystream was trivially breakable via crib-dragging for secrets > 32 bytes. AES-256-GCM provides proper confidentiality and built-in integrity verification regardless of secret length. - requirements.txt: added cryptography>=42.0.0 as explicit dependency.
utksh1
requested changes
May 27, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Requesting changes. mutation-testing, backend-tests, and formatting-hygiene are failing. Please make CI green and avoid bundling unrelated vault/config dependency changes into the mutation testing workflow PR.
Owner
|
Thanks for following up. Clarifying the change request so it is actionable: Why this is blocked: What to do next:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds mutation testing for the two most security-critical helper modules:
backend/secuscan/validation.pybackend/secuscan/redaction.pyHow
mutmut.toml— configures which files to mutate and which tests to run.github/workflows/mutation.yml— new targeted CI job that:backend/requirements-dev.txt— pinsmutmut>=3.5.0What was NOT changed
Verification
Run locally:
Closes #244