feat: add asset inventory page for discovered hosts and services#451
Open
aaniya22 wants to merge 6 commits into
Open
feat: add asset inventory page for discovered hosts and services#451aaniya22 wants to merge 6 commits into
aaniya22 wants to merge 6 commits into
Conversation
- Fix design tokens in ScanHistory to match SecuScan styling - Replace replacement-character separator with middle dot - Preserve selectedFindingId reset when switching scans - Add focused tests for ScanHistory scan selection
utksh1
requested changes
May 31, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Thanks for the asset inventory work. This cannot merge as-is: frontend-checks are failing, the PR removes the Settings route/nav entry, adds an AssetInventory.jsx page with inline/mock-style UI instead of the existing design system, calls /assets without a backend endpoint in this PR, includes unrelated package-lock churn, and bundles the scan-history sidebar changes from another PR. Please split this into focused PRs, restore Settings/Findings behavior, add a real backend/API contract, and make checks green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
What's changed
AssetInventory.jsxpage underfrontend/src/pages/showing all discovered hosts and services/inventoryroute inroutes.tsandApp.tsxGET /api/v1/assetsendpoint inbackend/secuscan/routes.pygetAssets()inapi.tsusing the existingrequest()helperFeatures
Testing