Skip to content

Conversation

@AlexSanchez-bit
Copy link
Contributor

Main changes

  • changes button position
  • added button icon
  • added an event to open echoes on alert details

@AlexSanchez-bit AlexSanchez-bit force-pushed the backlog/alert_echoes_button branch from 91259eb to 572b917 Compare October 10, 2025 21:46
@mjabascal10 mjabascal10 requested a review from Copilot October 13, 2025 14:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Echoes button styling and functionality in the alert management system. The changes move the Echoes button from a separate column to be integrated within the alert details view, add an icon to the button, and implement functionality to automatically expand echoes when clicking on alert details.

  • Added Echoes field configuration and moved the Echoes button into the data field render component
  • Updated button styling by removing borders and adding an echoes icon
  • Implemented automatic echoes expansion when viewing alert details for alerts with echoes

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
frontend/src/app/shared/constants/alert/alert-field.constant.ts Adds ALERT_ECHOES_FIELD constant and field configuration
frontend/src/app/data-management/alert-management/shared/components/data-field-render/data-field-render.component.ts Imports and exposes ALERT_ECHOES_FIELD constant
frontend/src/app/data-management/alert-management/shared/components/data-field-render/data-field-render.component.html Adds content projection for echoes field
frontend/src/app/data-management/alert-management/shared/components/alert-child-column/alert-child-column.component.scss Updates button styling and adds echoes icon filter
frontend/src/app/data-management/alert-management/shared/components/alert-child-column/alert-child-column.component.html Replaces text with icon and updates button layout
frontend/src/app/data-management/alert-management/alert-view/alert-view.component.ts Adds logic to auto-expand echoes on alert detail view and removes console.log
frontend/src/app/data-management/alert-management/alert-view/alert-view.component.html Moves echoes button from separate column to within data field render

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

mjabascal10 and others added 3 commits October 13, 2025 09:28
…lert-view.component.html

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lert-view.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nents/data-field-render/data-field-render.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mjabascal10 mjabascal10 merged commit 356939e into release/v11 Oct 13, 2025
@mjabascal10 mjabascal10 deleted the backlog/alert_echoes_button branch October 13, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants