Skip to content

Conversation

@AlexSanchez-bit
Copy link
Contributor

Main Changes

  • marked as false positive on rule tag creation as false positive

@mjabascal10 mjabascal10 requested a review from Copilot October 14, 2025 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in the alert management system where creating a false positive tag rule wasn't properly marking the alert as a false positive. The fix ensures that when creating a false positive tag rule, the system automatically includes the false positive tag and correctly identifies the rule as false positive.

  • Added isFalsePositiveRule input parameter to pass false positive context
  • Updated false positive detection logic to consider the rule context
  • Modified tag rule creation to automatically include false positive tag when appropriate

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
frontend/src/environments/environment.ts Changed server API URL configuration from localhost to IP address
frontend/src/app/data-management/alert-management/shared/components/alert-rule-create/alert-rule-create.component.ts Added false positive rule support with new input parameter and updated detection logic
frontend/src/app/data-management/alert-management/shared/components/alert-actions/alert-apply-tags/alert-tags-apply.component.ts Modified to pass false positive context when creating tag rules
frontend/src/app/data-management/alert-management/shared/components/alert-actions/alert-apply-tags/alert-tags-apply.component.html Updated template to call tag rule creation with false positive parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

mjabascal10 and others added 3 commits October 14, 2025 09:04
…nents/alert-rule-create/alert-rule-create.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nents/alert-actions/alert-apply-tags/alert-tags-apply.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nents/alert-actions/alert-apply-tags/alert-tags-apply.component.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mjabascal10 mjabascal10 merged commit f116e9f into release/v11 Oct 14, 2025
@mjabascal10 mjabascal10 deleted the backlog/alert_false_positive_tag branch October 14, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants