feat: add detail view for alerts in echoes component and improve aler… #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t display Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds inline expand/collapse functionality for alert echo rows, allowing users to view detailed alert information directly beneath the selected row without leaving the current context. The implementation includes conditional rendering of tags based on whether the alert is displayed in echo mode.
- Added
isEchoinput property to control display behavior in echo contexts - Implemented row click handler to toggle expanded state for individual alerts
- Conditionally hides tags section when viewing alerts in echo mode
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| alert-view-detail.component.ts | Added isEcho input property to differentiate echo view behavior |
| alert-view-detail.component.html | Conditionally hides tags section when displayed in echo mode |
| alert-echoes.component.ts | Added viewDetail method to toggle alert expansion state |
| alert-echoes.component.html | Implemented inline detail view with click handler and conditional rendering |
| alert-description.component.html | Added text wrapping class for better content display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../data-management/alert-management/shared/components/alert-echoes/alert-echoes.component.html
Outdated
Show resolved
Hide resolved
.../data-management/alert-management/shared/components/alert-echoes/alert-echoes.component.html
Outdated
Show resolved
Hide resolved
.../data-management/alert-management/shared/components/alert-echoes/alert-echoes.component.html
Outdated
Show resolved
Hide resolved
…nents/alert-echoes/alert-echoes.component.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nents/alert-echoes/alert-echoes.component.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…data handling Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>
…es' into backlog/add-detail-view-for-echoes # Conflicts: # frontend/src/app/data-management/alert-management/shared/components/alert-echoes/alert-echoes.component.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces inline expand/collapse functionality for alert echo rows. When a user clicks on a row in the alert list, detailed information for that specific alert is displayed directly beneath the row. This approach avoids opening side views or modals, keeping the user in context and improving workflow efficiency.