Correct conditional check for IP info search results #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `getIpInfo` method to fix the conditional check when evaluating the total hits from the Elasticsearch search result. Changed the condition from `hits.total().value() < 0` to `hits.total().value() <= 0` to correctly handle cases where no search results are found, preventing potential `IndexOutOfBoundsException`.
c3s4rfred
approved these changes
May 28, 2024
c3s4rfred
deleted the
bugfix/10.4/693-bug-index-out-of-bound-exception-in-visualization-of-type-coordinate-map
branch
dayat81
pushed a commit
to dayat81/utmstack
that referenced
this pull request
Aug 9, 2025
Updated the `getIpInfo` method to fix the conditional check when evaluating the total hits from the Elasticsearch search result. Changed the condition from `hits.total().value() < 0` to `hits.total().value() <= 0` to correctly handle cases where no search results are found, preventing potential `IndexOutOfBoundsException`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
getIpInfomethod to fix the conditional check when evaluating the total hits from the Elasticsearch search result. Changed the condition fromhits.total().value() < 0tohits.total().value() <= 0to correctly handle cases where no search results are found, preventing potentialIndexOutOfBoundsException.