error footer#4
Open
giulitruant wants to merge 2 commits intoutnfrrottads:todo-list-exercisefrom
giulitruant:todo-list-exercise
Open
error footer#4giulitruant wants to merge 2 commits intoutnfrrottads:todo-list-exercisefrom giulitruant:todo-list-exercise
giulitruant wants to merge 2 commits intoutnfrrottads:todo-list-exercisefrom
giulitruant:todo-list-exercise
Conversation
aotaduy
reviewed
May 21, 2020
| onItemStateChanged(item: TodoItem) { | ||
| onItemStateChanged(item: TodoItem) { | ||
| item.toggleCompleted(); | ||
| if(item.isCompleted){ |
Contributor
There was a problem hiding this comment.
no es bueno estar calculando los contadores aca, te convendria recorrer toda la coleccion y ver cuantos hay de cada uno cada vez
Contributor
There was a problem hiding this comment.
eso te simplificaria toda la logfica, ademas la logica de conteo deberia estar en el footer no aca
aotaduy
reviewed
May 21, 2020
| export class TodoFooterComponent implements OnInit { | ||
|
|
||
| // @Input() listChanged = []; | ||
| @Input() completed: any; |
Contributor
There was a problem hiding this comment.
yo le pasaria la lista cada vez que cambia y aca con dos funciones mostraria cuantos hay de cada uno,fijate en el otro PR que hay que le dije lo mismo
Contributor
There was a problem hiding this comment.
…el footer desde el componente todo-app
OscarDorronzoro
added a commit
to OscarDorronzoro/angular9-example
that referenced
this pull request
Sep 14, 2020
Abm article completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tal y como hablamos profe, le hago la PR para que me pueda ayudar con el footer que no me llegan los parametros de entrada al componente y no puedo mostrar la cantidad de tareas completas y pendientes....