Skip to content

Conversation

@xusd320
Copy link

@xusd320 xusd320 commented Dec 30, 2025

Thisl will improve performance a lot.

@xusd320 xusd320 requested a review from fireairforce December 30, 2025 06:20
@gemini-code-assist
Copy link

Summary of Changes

Hello @xusd320, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a performance optimization for Turbopack by adjusting the default verbosity of its internal tracing. It systematically changes the tracing level of many tracing::instrument macros and tracing::info_span! calls from info to trace. This modification ensures that detailed tracing information is only captured when explicitly requested (e.g., during debugging), thereby reducing the computational overhead of logging during normal operations and improving overall system performance.

Highlights

  • Tracing Level Adjustment: The default tracing level for numerous instrumented functions and spans across the Turbopack codebase has been changed from info to trace. This significantly reduces the verbosity of logs at the default info level, improving performance by decreasing the overhead associated with tracing.
  • Performance Optimization: This change directly addresses performance, as detailed trace level logging is now opt-in, only occurring when the tracing level is explicitly set to trace or higher, thereby reducing the computational overhead during normal operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xusd320 xusd320 changed the title perf(turbopack): use trace_spawn in tracing::instrument perf(turbopack): use trace_span in tracing::instrument Dec 30, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant performance improvement by changing the logging level of numerous tracing spans from info to trace. This change is applied consistently across a wide range of files in Turbopack, which will help reduce tracing overhead in production environments. The changes are extensive and cover areas like NAPI endpoints, project lifecycle, module graph operations, and low-level filesystem and task management functionalities.

I've reviewed the changes and they appear to be correct and well-executed. The mechanical nature of the change (replacing info_span! with trace_span! and level = "info" with level = "trace") is consistent throughout the PR.

A minor stylistic change from tracing::Level::TRACE to "trace" was also noted in some files, which seems to be for consistency.

Overall, this is a great contribution to improving Turbopack's performance.

P.S. There's a small typo in the PR description: 'Thisl' should be 'This'.

@xusd320 xusd320 merged commit 0285567 into utoo Dec 30, 2025
13 of 26 checks passed
xusd320 added a commit that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants