fix(pack): lock turbopack cache before persistent writes#2913
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a cross-platform persistent cache locking mechanism to prevent concurrent processes from accessing the same .turbopack cache. The implementation includes a native Rust module for file locking, integrated into the build and development workflows via NAPI. Feedback was provided regarding the use of a synchronous file system operation within an asynchronous function, which could potentially block the event loop.
7a0bba2 to
6fbe61f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fbe61f567
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📊 Performance Benchmark Report (with-antd)Utoopack Performance ReportReport ID: Executive Summary
Build Phase TimelineShows when each build phase is active and how much CPU it consumes.
Workload Distribution by Diagnostic Tier
Top 20 Tasks by Self-TimeSelf-time is the exclusive duration: time spent in the task itself, not in sub-tasks.
Critical Path AnalysisThe longest sequential dependency chains that determine wall-clock time.
Batching CandidatesHigh-volume tasks dominated by a single parent. If the parent can batch them,
Duration Distribution
Action Items
Report generated by Utoopack Performance Analysis Agent |
Summary
to solve windows persistent cache parallel write cuase os error 5:
closes: #2912
Align turbopack's: vercel/next.js#84428
Test Plan