Skip to content

added agent interface#33

Merged
ArnabChatterjee20k merged 2 commits into
mainfrom
appwrite-embedding-adapter
May 29, 2026
Merged

added agent interface#33
ArnabChatterjee20k merged 2 commits into
mainfrom
appwrite-embedding-adapter

Conversation

@ArnabChatterjee20k
Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR exposes the bulkEmbed capability through the Agent class, mirroring the existing embed method. The abstract bulkEmbed method was already defined on Adapter and implemented by all concrete adapters; this change makes it callable from the agent layer.

  • Adds Agent::bulkEmbed(array $texts) with proper PHPDoc (@param, @return, @throws) and the same getSupportForEmbeddings() guard as embed.
  • Delegates directly to $this->adapter->bulkEmbed($texts), which is consistent with how embed is handled.

Confidence Score: 5/5

Safe to merge — adds a thin delegation method that follows an established pattern and is backed by pre-existing adapter implementations.

The change is a small, self-contained addition that faithfully mirrors the existing embed method. The adapter-layer bulkEmbed abstract method and all concrete implementations were already in place, so there is no risk of missing implementations or broken contracts.

No files require special attention.

Important Files Changed

Filename Overview
src/Agents/Agent.php Adds bulkEmbed method that mirrors the existing embed pattern — checks embedding support then delegates to the adapter.

Reviews (2): Last reviewed commit: "linting" | Re-trigger Greptile

@ArnabChatterjee20k ArnabChatterjee20k merged commit c978583 into main May 29, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant