Skip to content

Feat: Add update attribute methods#132

Merged
TorstenDittmann merged 6 commits intomainfrom
feat-update-attribute-methods
May 16, 2022
Merged

Feat: Add update attribute methods#132
TorstenDittmann merged 6 commits intomainfrom
feat-update-attribute-methods

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented May 13, 2022

New methods (for migration use, as of right now):

  • updateAttributeRequired
  • updateAttributeFormat
  • updateAttributeFormatOptions
  • updateAttributeFormatFilters
  • updateAttributeDefault
  • updateAttribute (to update size&type&signed&array)

The new private method introduced to prevent code duplication:

  • updateAttributeMeta

TODO:

  • Write tests
  • Implement adapter->updateAttribute

Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks already so much better 💪🏻

@TorstenDittmann TorstenDittmann marked this pull request as ready for review May 16, 2022 08:55
@TorstenDittmann TorstenDittmann merged commit c9178bf into main May 16, 2022
@TorstenDittmann TorstenDittmann deleted the feat-update-attribute-methods branch May 16, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants