Default boolean

[fogelito]

Test the boolean default value.

Summary by CodeRabbit

• Tests
  • Enhanced document update tests to include a boolean attribute, ensuring its correct handling during batch updates.

[coderabbitai]

Warning

Rate limit exceeded

@abnegate has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 51 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ff9177b2-39ad-4929-8796-5aad58d96dca

📥 Commits

Reviewing files that changed from the base of the PR and between 157f0cd and 09db63b.

📒 Files selected for processing (1)

• tests/e2e/Adapter/Scopes/DocumentTests.php

📝 Walkthrough

Walkthrough

The test method testUpdateDocuments in the end-to-end test suite was updated to include a new boolean attribute in the collection schema and in the test documents. Additional assertions were added to verify the correct handling of this boolean attribute during batch document updates.

Changes

File(s)	Change Summary
tests/e2e/Adapter/Scopes/DocumentTests.php	Enhanced testUpdateDocuments to add and test a boolean attribute in schema and document updates

Poem

In the warren of tests, a new field appears,
A boolean hop, dispelling old fears.
True in the meadow, false in the den,
The rabbits ensure it works again and again.
With every update, we check and we cheer—
For code that is clear, and bugs disappear! 🐇

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch default-boolean

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 14 minutes and 51 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR extends the testUpdateDocuments test with a boolean attribute (default false) to verify that a partial updateDocuments call does not clobber unrelated fields. The intent is sound, but the default value itself is never exercised — every document is created with 'boolean' => true, so the default: false path is never hit.

Confidence Score: 3/5

Safe to merge if the intent is only to guard against boolean fields being zeroed out during updates; needs work if the goal is to test the default-value code path.

One P1 finding: the declared purpose of the PR (testing boolean defaults) is not actually tested — no document is ever created without the boolean field, so the default: false branch is never executed. This leaves the primary motivation of the PR unvalidated.

tests/e2e/Adapter/Scopes/DocumentTests.php

Important Files Changed

Filename	Overview
tests/e2e/Adapter/Scopes/DocumentTests.php	Adds a boolean attribute with default: false to the testUpdateDocuments test and asserts its value is preserved after a partial update — but never creates a document without the field, so the default-value path is untested.

Comments Outside Diff (1)

1. tests/e2e/Adapter/Scopes/DocumentTests.php, line 4653-4659 (link)

   Default value not actually exercised

   The PR description says this tests the boolean default value, but every document is created with 'boolean' => true explicitly. The default: false path is never triggered — no document is created without the boolean field, which is the scenario that would exercise the default. Consider adding at least one document created without the boolean key and asserting it reads back as false.

_{Reviews (1): Last reviewed commit: "Merge branch 'main' into default-boolean" | Re-trigger Greptile}