Skip to content

convertQueries remove static #634

Merged
abnegate merged 1 commit intomainfrom
convert-queries
Jul 23, 2025
Merged

convertQueries remove static #634
abnegate merged 1 commit intomainfrom
convert-queries

Conversation

@fogelito
Copy link
Contributor

@fogelito fogelito commented Jul 23, 2025

Summary by CodeRabbit

  • Refactor
    • Updated internal method usage to improve consistency in how queries are handled within the database operations. No changes to user-facing functionality.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

Walkthrough

The changes update the convertQueries method in the Database class from a static to an instance method. All internal calls to convertQueries within the class are modified to use the instance context ($this) instead of the static context (self). The method's logic remains unchanged.

Changes

File(s) Change Summary
src/Database/Database.php Changed convertQueries from static to instance method; updated all internal calls from self::convertQueries to $this->convertQueries in find(), count(), and sum() methods.

Estimated code review effort

1 (~2 minutes)

Poem

In the warren of code, a small hop today,
Static to instance, the method finds its way.
No more self::, now $this-> will do,
Query conversions, reliable and true.
A gentle tweak, a bunny’s delight—
The database hops on, working just right! 🐇


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7a26a2 and e2e57cd.

📒 Files selected for processing (1)
  • src/Database/Database.php (4 hunks)
🔇 Additional comments (4)
src/Database/Database.php (4)

6036-6036: LGTM: Correct conversion to instance method call.

The change from self::convertQueries to $this->convertQueries is appropriate for the conversion from static to instance method.


6196-6196: LGTM: Correct conversion to instance method call.

The change from self::convertQueries to $this->convertQueries is consistent with the method signature change and maintains the same functionality.


6240-6240: LGTM: Correct conversion to instance method call.

The instance method call is properly implemented, maintaining consistency with the other conversions in this refactoring.


6609-6609: No remaining static calls to convertQueries

All grep searches for ::convertQueries, self::convertQueries, and static.*convertQueries returned no matches outside of instance calls. Every invocation now uses $this->convertQueries(), so converting this method to an instance method will not break any existing usages.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abnegate abnegate merged commit d52f74b into main Jul 23, 2025
15 checks passed
@abnegate abnegate deleted the convert-queries branch July 23, 2025 15:19
This was referenced Jul 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request Aug 20, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants