-
Notifications
You must be signed in to change notification settings - Fork 55
Big int #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Big int #847
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
af321ee
Implement BIGINT support across database adapters and add getLimitFor…
ArnabChatterjee20k 3137084
Add support for VAR_BIGINT in Database and Attribute classes
ArnabChatterjee20k b5c7447
Add tests for BIGINT attribute handling and validation limits
ArnabChatterjee20k bd14576
Update getLimitForBigInt method to return 4294967295 for Mongo and SQ…
ArnabChatterjee20k acfeae1
updated bigint mongo
ArnabChatterjee20k 07358a5
Enhance BIGINT handling in MariaDB and SQL adapters
ArnabChatterjee20k 909d8a5
Add VAR_BIGINT to Database class attribute types
ArnabChatterjee20k f2acd8c
Enhance BIGINT size limit validation in Database class
ArnabChatterjee20k 602eefc
Refine BIGINT handling in Structure and Filter validators
ArnabChatterjee20k 14828d9
Refine BIGINT type determination in Postgres adapter
ArnabChatterjee20k 080de0e
Remove BIGINT size limit validation from Database and Validator classes
ArnabChatterjee20k 73e917e
Add support for VAR_BIGINT in Database class and corresponding tests
ArnabChatterjee20k ef5c779
updated tests
ArnabChatterjee20k 4490a49
big int validator for attribute
ArnabChatterjee20k 4c5aeb1
updated
ArnabChatterjee20k 8137486
updated attribute validator
ArnabChatterjee20k b87cf3a
updated
ArnabChatterjee20k ad89dab
Merge remote-tracking branch 'origin/main' into big-init
ArnabChatterjee20k 5ee5d1b
Add support for unsigned big integers in database adapters and valida…
ArnabChatterjee20k 38e31f4
updated
ArnabChatterjee20k cafb353
updated
ArnabChatterjee20k dbe3537
Refactor attribute size handling in database adapters to support both…
ArnabChatterjee20k ba45e22
Enhance attribute validation to support string type for big integers
ArnabChatterjee20k 75a7f28
Refactor attribute size handling to enforce integer type across datab…
ArnabChatterjee20k 946b841
updated
ArnabChatterjee20k fafacee
updated
ArnabChatterjee20k fe3bf72
updated
ArnabChatterjee20k d3282bc
updated
ArnabChatterjee20k 1761511
updated the type for big int validator
ArnabChatterjee20k 0e43fd4
updated
ArnabChatterjee20k 9c3defb
fix: align bigint handling and validator refactors from PR feedback
Copilot ae10b94
fix: keep filter supportForAttributes mutability unchanged
Copilot a58547e
refactor: centralize bigint size normalization and extend coverage
Copilot 7315ba2
fixed the attribute ordering
ArnabChatterjee20k 6ff2d7b
updated
ArnabChatterjee20k 602f0cd
updated
ArnabChatterjee20k 89013ff
updated pool
ArnabChatterjee20k dd1077a
Merge remote-tracking branch 'origin/main' into big-init
ArnabChatterjee20k ee8895a
updated
ArnabChatterjee20k 25a3fcd
Update src/Database/Validator/Attribute.php
abnegate 2ae3837
Update src/Database/Validator/Attribute.php
abnegate 1968ec4
(fix): CI — pass signed flag to validateDefaultTypes for bigint defaults
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -912,6 +912,16 @@ public function getLimitForInt(): int | |
| return 4294967295; | ||
| } | ||
|
|
||
| /** | ||
| * Get max BIGINT limit | ||
| * | ||
| * @return int | ||
| */ | ||
| public function getLimitForBigInt(): int | ||
| { | ||
| return Database::MAX_BIG_INT; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here going other way around |
||
| } | ||
|
ArnabChatterjee20k marked this conversation as resolved.
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Get maximum column limit. | ||
| * https://mariadb.com/kb/en/innodb-limitations/#limitations-on-schema | ||
|
|
@@ -1207,6 +1217,10 @@ public function getAttributeWidth(Document $collection): int | |
| } | ||
| break; | ||
|
|
||
| case Database::VAR_BIGINT: | ||
| $total += 8; // BIGINT 8 bytes | ||
| break; | ||
|
|
||
| case Database::VAR_FLOAT: | ||
| $total += 8; // DOUBLE 8 bytes | ||
| break; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb, postgresql, sqlite doesn't support unsigned bigint