Skip to content

Support domains 2.x#19

Merged
ChiragAgg5k merged 1 commit into
mainfrom
chore/support-domains-2
May 13, 2026
Merged

Support domains 2.x#19
ChiragAgg5k merged 1 commit into
mainfrom
chore/support-domains-2

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented May 13, 2026

Summary

  • Bump utopia-php/domains to ^2.0.
  • Refresh composer.lock for the domains 2.x dependency graph.

Testing

  • composer validate

Notes

  • This unblocks consumers upgrading to the latest Utopia cache stack through domains 2.x.

@ChiragAgg5k ChiragAgg5k force-pushed the chore/support-domains-2 branch from 49f7f5b to 5e2823a Compare May 13, 2026 05:00
@ChiragAgg5k ChiragAgg5k merged commit 115e24a into main May 13, 2026
7 checks passed
@ChiragAgg5k ChiragAgg5k deleted the chore/support-domains-2 branch May 13, 2026 05:01
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR updates the utopia-php/domains constraint and refreshes composer.lock, pulling in domains 2.0.0 along with several transitive bumps (cache 2.1.0, new circuit-breaker 0.3.0, telemetry 0.3.0, multiple Symfony/OpenTelemetry packages).

  • The composer.json constraint changes from ^1.0 to ^2.0 only, but the PR description says the intent is to support 2.x alongside 1.x; if both ranges should be accepted, the constraint should be ^1.0 || ^2.0.
  • The declared php: ">=8.0" minimum is no longer accurate — utopia-php/cache 2.1.0 (pulled in transitively via domains 2.0.0) requires php: ">=8.3", meaning consumers on PHP 8.0–8.2 will hit a resolution failure despite the advertised compatibility.

Confidence Score: 3/5

Two issues in composer.json need to be resolved before merging: the constraint change drops 1.x support contrary to the stated goal, and the php minimum is understated relative to what the resolved dependency tree actually requires.

The constraint replacement conflicts with the PR stated goal of dual-range support, and the php minimum declaration is now misleading because utopia-php/cache 2.1.0 requires PHP 8.3. Both issues affect real consumers and are straightforward to fix.

composer.json — the require constraint for utopia-php/domains and the php minimum version both need updating.

Important Files Changed

Filename Overview
composer.json Bumps utopia-php/domains constraint from ^1.0 to ^2.0, but the PR intends dual 1.x/2.x support; also does not raise the php minimum despite transitive deps now requiring >=8.3
composer.lock Lock file updated to reflect utopia-php/domains 2.0.0; also bumps several transitive deps (cache 2.1.0, circuit-breaker 0.3.0 new, telemetry 0.3.0, validators 0.2.2, multiple Symfony and OpenTelemetry packages); looks mechanically correct for the new resolution

Reviews (1): Last reviewed commit: "Support domains 2.x" | Re-trigger Greptile

Comment thread composer.json
@@ -27,7 +27,7 @@
"require": {
"php": ">=8.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PHP minimum version is now understated

composer.json declares php: ">=8.0", but the resolved dependency tree now requires PHP 8.3+: utopia-php/cache 2.1.0 specifies php: ">=8.3" and utopia-php/circuit-breaker 0.3.0 specifies php: ">=8.2". Any consumer (or CI matrix) still on PHP 8.0, 8.1, or 8.2 will hit a dependency resolution failure when installing this package, even though the declared constraint implies those versions are fine.

Comment thread composer.json
"php": ">=8.0",
"utopia-php/validators": "0.*",
"utopia-php/domains": "^1.0"
"utopia-php/domains": "^2.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Constraint drops 1.x support instead of adding 2.x alongside it

The PR description says "Allow utopia-php/domains 2.x alongside the existing 1.x range", but the change replaces ^1.0 with ^2.0, silently removing 1.x compatibility. Consumers currently pinned to ^1.0 will receive a conflict when they pull in this version of utopia-php/emails. If both major versions should be accepted, the constraint needs to be a union.

Suggested change
"utopia-php/domains": "^2.0"
"utopia-php/domains": "^1.0 || ^2.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant