Support domains 2.x#19
Conversation
49f7f5b to
5e2823a
Compare
Greptile SummaryThis PR updates the
Confidence Score: 3/5Two issues in composer.json need to be resolved before merging: the constraint change drops 1.x support contrary to the stated goal, and the php minimum is understated relative to what the resolved dependency tree actually requires. The constraint replacement conflicts with the PR stated goal of dual-range support, and the php minimum declaration is now misleading because utopia-php/cache 2.1.0 requires PHP 8.3. Both issues affect real consumers and are straightforward to fix. composer.json — the require constraint for utopia-php/domains and the php minimum version both need updating. Important Files Changed
Reviews (1): Last reviewed commit: "Support domains 2.x" | Re-trigger Greptile |
| @@ -27,7 +27,7 @@ | |||
| "require": { | |||
| "php": ">=8.0", | |||
There was a problem hiding this comment.
PHP minimum version is now understated
composer.json declares php: ">=8.0", but the resolved dependency tree now requires PHP 8.3+: utopia-php/cache 2.1.0 specifies php: ">=8.3" and utopia-php/circuit-breaker 0.3.0 specifies php: ">=8.2". Any consumer (or CI matrix) still on PHP 8.0, 8.1, or 8.2 will hit a dependency resolution failure when installing this package, even though the declared constraint implies those versions are fine.
| "php": ">=8.0", | ||
| "utopia-php/validators": "0.*", | ||
| "utopia-php/domains": "^1.0" | ||
| "utopia-php/domains": "^2.0" |
There was a problem hiding this comment.
Constraint drops 1.x support instead of adding 2.x alongside it
The PR description says "Allow utopia-php/domains 2.x alongside the existing 1.x range", but the change replaces ^1.0 with ^2.0, silently removing 1.x compatibility. Consumers currently pinned to ^1.0 will receive a conflict when they pull in this version of utopia-php/emails. If both major versions should be accepted, the constraint needs to be a union.
| "utopia-php/domains": "^2.0" | |
| "utopia-php/domains": "^1.0 || ^2.0" |
Summary
utopia-php/domainsto^2.0.composer.lockfor the domains 2.x dependency graph.Testing
Notes