Implement Retry functionality into the fetch library #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Jan 17, 2025
src/Client.php
Outdated
| while (true) { | ||
| $res = $callback(); | ||
|
|
||
| if ($res->getStatusCode() !== 500 && $res->getStatusCode() !== 503 || $attempts >= $this->maxRetries) { |
Member
There was a problem hiding this comment.
Let's make the codes configurable (setRetryStatusCodes), some clients may want to retry on different codes
src/Client.php
Outdated
| * @return mixed | ||
| * @throws \Exception | ||
| */ | ||
| private function retry(callable $callback): mixed |
abnegate
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retry functionality to the fetch client; by default, it is disabled, and
maxRetriesis set to 0.If maxRetries is set to a non-0 value, the code will automatically retry requests that fail with either a 500 or 503 value up to the number of maxRetries. If the response is still 500/503, it will then return that response.