Skip to content

Feat: Improve hostname validator#85

Merged
eldadfux merged 1 commit intomasterfrom
improve-hostname-validator
Feb 27, 2023
Merged

Feat: Improve hostname validator#85
eldadfux merged 1 commit intomasterfrom
improve-hostname-validator

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Dec 7, 2022

Problems with previous solution:

  • Too complex

  • Allowed multiple wildcards like *.*.gitpod.io which is not allowed by standard

  • Wildcard only allowed one level of subdomain, not all of them

  • Wildcard was allowed in middle of domain like api.*.com and myapp.*. Again, not part of standard

  • New logic implemented

  • Tests updated

Copy link
Contributor

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@eldadfux eldadfux merged commit 9b2e1fc into master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants