Skip to content

Remove deprecated curl_close calls#175

Merged
loks0n merged 1 commit intomainfrom
codex/remove-curl-close-php85
Apr 29, 2026
Merged

Remove deprecated curl_close calls#175
loks0n merged 1 commit intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Removes two curl_close() calls — one in src/Migration/Target.php and one in tests/Migration/E2E/Sources/Base.php — that became no-ops in PHP 8.0 and are deprecated in PHP 8.5. The removal is correct and has no behavioral impact on supported PHP versions.

Confidence Score: 5/5

This PR is safe to merge; it removes two deprecated no-op calls with no behavioral change.

The change is minimal and correct — curl_close() has been a no-op since PHP 8.0 and is deprecated in PHP 8.5. Removing it eliminates deprecation warnings without affecting runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
src/Migration/Target.php Removes the now-deprecated curl_close($ch) call after the cURL request; no behavioral change on PHP 8.0+.
tests/Migration/E2E/Sources/Base.php Removes the deprecated curl_close($ch) call in the test helper; mirrors the production change.

Reviews (1): Last reviewed commit: "Remove deprecated curl_close calls" | Re-trigger Greptile

@loks0n loks0n merged commit 952a4df into main Apr 29, 2026
4 checks passed
@loks0n loks0n deleted the codex/remove-curl-close-php85 branch April 29, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants