Add generic TCP connection handler hook#3
Conversation
Greptile SummaryThis PR replaces the hardcoded PostgreSQL SSLRequest interception in both the event-driven and coroutine TCP servers with a generic
Confidence Score: 5/5Safe to merge; the architectural shift is clean and consistent across both server implementations. The core forwarding and TLS-upgrade paths are correctly refactored. The removed SSLRequest handling in the event-driven server was unused in practice (Swoole's SWOOLE_SSL mode does TLS immediately on accept, before any PostgreSQL wire bytes arrive). The only open items are documentation and test-quality nits that do not affect runtime correctness. tests/TLSTest.php relies on source-code string matching rather than runtime assertions; src/Server/TCP/Config.php and src/Server/TCP/Swoole/Coroutine.php would benefit from a docblock describing the connectionHandler return-value contract and the accessibility of startTLS(). Important Files Changed
Reviews (5): Last reviewed commit: "fix: move tcp protocol handling behind h..." | Re-trigger Greptile |
aef9d5d to
4fbf604
Compare
Summary
Verification