Add Swoole coroutine concurrency#84
Conversation
Greptile SummaryThis PR introduces adapter-owned
Confidence Score: 5/5Safe to merge; the concurrency and context-isolation logic is sound for the expected consumer contract, and the concerns raised are edge-case design considerations rather than breakages in the normal flow. The core changes are well-tested: per-message context reset is verified by testContextDoesNotLeakBetweenMessages, concurrent coroutine behaviour by testMaxCoroutinesConsumeInParallel, and full error collection by testPreservesAllCoroutineConsumerErrors. The only flagged items are a redundant property assignment and a context() fallback that could corrupt shared state only if a consumer calls errorCallback with a non-null message without having first called messageCallback — an atypical consumer contract violation. src/Queue/Adapter/Swoole.php — the context() fallback to resources() and the redundant maxCoroutines assignment are worth a quick look before merging. Important Files Changed
Reviews (3): Last reviewed commit: "Add Swoole coroutine concurrency" | Re-trigger Greptile |
0ec38a5 to
6e479b7
Compare
6e479b7 to
88a5431
Compare
Summary
Tests