Skip to content

chore: fix implicit deprecated warnings #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChiragAgg5k merged 1 commit into from
Feb 10, 2026
Merged

chore: fix implicit deprecated warnings #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Storage/Device/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function getRoot(): string
* @param string|null $prefix
* @return string
*/
public function getPath(string $filename, string $prefix = null): string
public function getPath(string $filename, ?string $prefix = null): string
{
return $this->getAbsolutePath($this->getRoot().DIRECTORY_SEPARATOR.$filename);
}
Expand Down Expand Up @@ -270,7 +270,7 @@ public function abort(string $path, string $extra = ''): bool
*
* @throws Exception
*/
public function read(string $path, int $offset = 0, int $length = null): string
public function read(string $path, int $offset = 0, ?int $length = null): string
{
if (! $this->exists($path)) {
throw new NotFoundException('File not found');
Expand Down
6 changes: 3 additions & 3 deletions src/Storage/Device/S3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public function getRoot(): string
* @param string|null $prefix
* @return string
*/
public function getPath(string $filename, string $prefix = null): string
public function getPath(string $filename, ?string $prefix = null): string
{
return $this->getRoot().DIRECTORY_SEPARATOR.$filename;
}
Expand Down Expand Up @@ -410,12 +410,12 @@ public function abort(string $path, string $extra = ''): bool
*
* @param string $path
* @param int offset
* @param int length
* @param int|null length
* @return string
*
* @throws \Exception
*/
public function read(string $path, int $offset = 0, int $length = null): string
public function read(string $path, int $offset = 0, ?int $length = null): string
{
unset($this->amzHeaders['x-amz-acl']);
unset($this->amzHeaders['x-amz-content-sha256']);
Expand Down
4 changes: 2 additions & 2 deletions src/Storage/Device/Telemetry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function getRoot(): string
return $this->underlying->getRoot();
}

public function getPath(string $filename, string $prefix = null): string
public function getPath(string $filename, ?string $prefix = null): string
{
return $this->measure(__FUNCTION__, $filename, $prefix);
}
Expand All @@ -74,7 +74,7 @@ public function abort(string $path, string $extra = ''): bool
return $this->measure(__FUNCTION__, $path, $extra);
}

public function read(string $path, int $offset = 0, int $length = null): string
public function read(string $path, int $offset = 0, ?int $length = null): string
{
return $this->measure(__FUNCTION__, $path, $offset, $length);
}
Expand Down