Skip to content

Fix chunked upload tmp path#30

Merged
eldadfux merged 2 commits intomainfrom
fix-chunked-upload-tmp-path
Feb 20, 2022
Merged

Fix chunked upload tmp path#30
eldadfux merged 2 commits intomainfrom
fix-chunked-upload-tmp-path

Conversation

@lohanidamodar
Copy link
Copy Markdown
Contributor

  • Chunked upload was using tmp directory to store logs and chunks in the provided path's parent directory
  • If the multiple files had same first four chars, they would use the same parent directory so shared the tmp folder
  • Abort method remove tmp folder so, if two files had tmp files, after aborting the first file, second would not abort
  • Fixed by appending file name to the tmp directory name tmp now tmp_filename
  • This occurred mostly with Appwrite's auto generated ID as they seems to share first four chars for a quite some time

@eldadfux eldadfux merged commit 1921d5d into main Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants