Digitalocean spaces adapter#5
Merged
eldadfux merged 3 commits intoutopia-php:mainfrom Jan 31, 2021
lohanidamodar:feat-do-spaces-adapter
Merged
Digitalocean spaces adapter#5eldadfux merged 3 commits intoutopia-php:mainfrom lohanidamodar:feat-do-spaces-adapter
eldadfux merged 3 commits intoutopia-php:mainfrom
lohanidamodar:feat-do-spaces-adapter
Conversation
Contributor
Author
|
@eldadfux I have run the tests locally on my own spaces instance and everything is working. |
Member
|
Probably a good time to add a list of supported adapters on the README. I think you should also adjust the description of the repo on the top section of it. |
Contributor
Author
|
@eldadfux I believe we can also have constants in Storage class regarding various supported device adapters, what do you think? |
Member
Good call! |
Contributor
Author
|
@eldadfux have made the requested updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, adds DoSpaces adapter which extends S3 adapter to easily support DigitalOcean Spaces storage.