feat: add LZ4 compression in storage#55
Conversation
|
@aloks98 Thanks for the PR! 🤯 Please give us some time to review it. |
@aloks98, compressing doesn't always yield a smaller file, especially really small files, already compressed files, and files with totally random data. I tested your implementation on the RGB 8 bit version of the artificial image here and a file compressed to 13% of the original. |
|
@aloks98 Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon! |
christyjacob4
left a comment
There was a problem hiding this comment.
Please address the comments
|
hey @christyjacob4 |
stnguyen90
left a comment
There was a problem hiding this comment.
Sorry, would you please make some additional changes? It seems like the image is failing to build.
|
Alright, got it! |
|
Thank you! 🙏 |
|
Please sync your branch with |
…Z4-compression-for-storage
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |

I have added the LZ4 package for compression, but I cannot get over the fact that the compressed sizes are coming greater than the actual file sizes. Is there something I am missing? Can somebody please help me with this?