Skip to content

Fixed China amazon zone issue#68

Merged
christyjacob4 merged 8 commits intoutopia-php:mainfrom
nimocat:main
Feb 19, 2023
Merged

Fixed China amazon zone issue#68
christyjacob4 merged 8 commits intoutopia-php:mainfrom
nimocat:main

Conversation

@nimocat
Copy link
Copy Markdown
Contributor

@nimocat nimocat commented Oct 29, 2022

If using amazon in China, the host should switch from amazonaws.com to amazonaws.cn

@PineappleIOnic
Copy link
Copy Markdown

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

Copy link
Copy Markdown
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Comment thread src/Storage/Device/S3.php Outdated
Comment thread src/Storage/Device/S3.php Outdated
@christyjacob4 christyjacob4 merged commit 0b3d0e6 into utopia-php:main Feb 19, 2023
@christyjacob4
Copy link
Copy Markdown
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants