Feat: Contains validator#9
Conversation
Greptile SummaryThis PR introduces a new
Confidence Score: 4/5The core validation logic is correct and the test suite is thorough, but unresolved issues flagged in prior review threads about non-string pattern elements causing unhandled TypeErrors should be addressed before merging. The new Contains validator is well-structured: it correctly guards against non-string values, uses mb_strtolower with explicit UTF-8 encoding, and is backed by comprehensive tests. The outstanding concern raised in prior threads — that non-string elements inside the $patterns array trigger an unhandled TypeError in both isValid() and getDescription() — remains unaddressed in this revision. src/Validator/Contains.php — specifically the constructor, which does not validate that all elements of $patterns are strings. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'feat-contains-validator' o..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…hp/validators into feat-contains-validator
No description provided.