Skip to content

Remove deprecated curl_close calls#96

Merged
ChiragAgg5k merged 2 commits intomainfrom
codex/remove-curl-close-php85
Apr 29, 2026
Merged

Remove deprecated curl_close calls#96
ChiragAgg5k merged 2 commits intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

This PR removes the sole curl_close($ch) call in src/VCS/Adapter.php. Since PHP 8.0 cURL handles are managed by object lifetime, and since PHP 8.5 explicitly deprecates curl_close(), this is the correct cleanup. A grep of the repo confirms no other curl_close calls remain.

Confidence Score: 5/5

Safe to merge — a trivial one-line removal with no behavioral impact on any supported PHP version.

The change is a no-op on PHP 8.0+ and harmless on older versions; no logic is altered. No remaining curl_close calls were found in the repository.

No files require special attention.

Important Files Changed

Filename Overview
src/VCS/Adapter.php Removed the single curl_close($ch) call (and its trailing blank line) — no other curl_close calls remain in the repo.

Reviews (2): Last reviewed commit: "Clean up curl_close removal formatting" | Re-trigger Greptile

Comment thread src/VCS/Adapter.php
@ChiragAgg5k ChiragAgg5k merged commit eb67358 into main Apr 29, 2026
3 of 5 checks passed
@ChiragAgg5k ChiragAgg5k deleted the codex/remove-curl-close-php85 branch April 29, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant