Skip to content
This repository was archived by the owner on May 27, 2025. It is now read-only.

refactor(examples): Save ckbVirtualTxResult locally #193

Merged
merged 2 commits into from
May 26, 2024
Merged

refactor(examples): Save ckbVirtualTxResult locally #193

merged 2 commits into from
May 26, 2024

Conversation

@Dawn-githup
Copy link
Contributor

@Dawn-githup Dawn-githup commented May 24, 2024

Main Changes:

  • Logging Implementation: Added functionality to save ckbVirtualTxResult into a log file in examples/rgbpp/*.
  • Comments Addition: Included comments within the codebase to remind developers to adhere to the suggestion of saving ckbVirtualTxResult before finalizing isomorphic transactions.

@Dawn-githup Dawn-githup requested review from Flouse and duanyytop May 24, 2024 18:12
@Dawn-githup Dawn-githup mentioned this pull request May 24, 2024
Closed
@Flouse Flouse linked an issue May 25, 2024 that may be closed by this pull request
Save ckbVirtualTxResult in the code examples #192
Closed
Flouse
Flouse approved these changes May 25, 2024
View reviewed changes
duanyytop
duanyytop reviewed May 26, 2024
View reviewed changes
duanyytop
duanyytop reviewed May 26, 2024
View reviewed changes
@Dawn-githup Dawn-githup requested a review from duanyytop May 26, 2024 02:16
@Flouse Flouse merged commit f4d18fa into develop May 26, 2024
@Flouse Flouse deleted the feat/save-ckbvirtualtx-result branch May 26, 2024 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Flouse Flouse Flouse approved these changes

@duanyytop duanyytop duanyytop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Save ckbVirtualTxResult in the code examples

4 participants

@Dawn-githup @Flouse @duanyytop