Skip to content
This repository was archived by the owner on May 27, 2025. It is now read-only.

test: resolve integration test failures due to insufficient test tokens #262

Merged
Flouse merged 2 commits into from
Jul 27, 2024
Merged

test: resolve integration test failures due to insufficient test tokens #262

Flouse merged 2 commits into from
Jul 27, 2024

Conversation

@Dawn-githup
Copy link
Contributor

@Dawn-githup Dawn-githup commented Jul 26, 2024

Main Changes:

  • Switched from Signet to Testnet3 for testing due to insufficient Signet test resources
  • Added pull_request trigger for tests
  • Updated btcConfirmationBlocks in btc-leap-ckb to 20 instead of using the default value of 6"

@Dawn-githup Dawn-githup mentioned this pull request Jul 26, 2024
Open
6 tasks
Flouse
Flouse previously approved these changes Jul 26, 2024
View reviewed changes
.github/workflows/integration-test.yaml

on:
workflow_dispatch:
pull_request:
Copy link
Contributor

@Flouse Flouse Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you want save some tBTC, you might consider running a pull_request_target workflow when a pull request merges.

Copy link
Contributor Author

@Dawn-githup Dawn-githup Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want save some tBTC, you might consider running a pull_request_target workflow when a pull request merges.

We have enough tBTC available, so we can conduct tests early.

duanyytop
duanyytop reviewed Jul 27, 2024
View reviewed changes
@Flouse Flouse enabled auto-merge July 27, 2024 02:15
@Flouse Flouse added this pull request to the merge queue Jul 27, 2024
Merged via the queue into develop with commit a73806c Jul 27, 2024
@Flouse Flouse deleted the fix/integration-tests branch July 27, 2024 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ShookLyngs ShookLyngs Awaiting requested review from ShookLyngs

2 more reviewers

@Flouse Flouse Flouse approved these changes

@duanyytop duanyytop duanyytop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dawn-githup @Flouse @duanyytop