This repository was archived by the owner on May 27, 2025. It is now read-only.
feat: add offline mode support for compatible xUDT type scripts #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanyytop
reviewed
Feb 14, 2025
packages/ckb/src/utils/ckb-tx.ts
Outdated
| */ | ||
| export const isCompatibleUDTTypesSupported = (type: CKBComponents.Script): boolean => { | ||
| const compatibleList = CompatibleXUDTRegistry.getCompatibleTokens(); | ||
| export const isCompatibleUDTTypesSupported = (type: CKBComponents.Script, offline: boolean = false): boolean => { |
Collaborator
There was a problem hiding this comment.
It is recommended that all isOffline parameters are optional, otherwise many functions will be incompatible
Contributor
Author
There was a problem hiding this comment.
Agreed. I've updated throwErrorWhenRgbppCellsInvalid to mark isOffline as optional as well. Using an optional parameter instead of a default value better reflects its optionality. Thanks for the feedback!
duanyytop
approved these changes
Feb 14, 2025
ShookLyngs
approved these changes
Feb 17, 2025
Flouse
approved these changes
Feb 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces offline mode support for compatible xUDT type scripts by adding an optional
offlineparameter to related methods. That is, if a user chooses to stay completely offline during the transaction building process, the compatible xUDT type scripts used will be the local ones instead of fetching them from the network.The
offlinebehavior is determined by thevendorCellDepsparameter, so there's no need for an extra parameter. Given the current implementation of usingrgbpp-sdkin offline mode, it's safe to deduce the user's intention simply by checking whethervendorCellDepsis provided.Compatible xUDT testing transactions on Testnet3 in offline mode: