Fix check on Windows & add CI#22
Merged
Merged
Conversation
Contributor
Author
|
Does check not save too many time compared with build? |
Collaborator
|
CI Check is fine for now. I used the rustix consts because GNU explicitly documented using the libc consts for this, but rolling our own consts is fine for now. Depending on whether we end up needing rustix in the intrepreter we'll get this cfg-gated for non-*nix instead. Ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't like to have our own consts, but
std::process::ExitCodeis not i32...Closes #18